WIP: Django 6 #1236
Open
WIP: Django 6 #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR upgrades the project to Django 6, which introduces breaking changes requiring updates to Django APIs and configuration.
- Updated Django version dependency from ~5.2.7 to ~6.0
- Replaced deprecated
checkparameter withconditionin CheckConstraint across models and migrations - Refactored test runner to remove multiprocessing workarounds and simplify worker initialization
- Added django.contrib.postgres to installed apps
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated Django dependency to version 6.0 |
| tests/settings.py | Added django.contrib.postgres to INSTALLED_APPS |
| resolwe/test_helpers/test_runner.py | Removed multiprocessing workaround and simplified worker initialization logic |
| resolwe/permissions/models.py | Replaced deprecated check parameter with condition in CheckConstraint |
| resolwe/permissions/migrations/0001_initial.py | Replaced deprecated check parameter with condition in migration CheckConstraint |
| resolwe/flow/models/annotations.py | Replaced deprecated check parameter with condition in CheckConstraint |
| resolwe/flow/migrations/0008_annotations.py | Replaced deprecated check parameter with condition in migration CheckConstraint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| """Standard parallel suite with a custom worker initializer.""" | ||
|
|
||
| init_worker = _custom_worker_init(ParallelTestSuite.init_worker) | ||
| init_worker = partial(_custom_worker_init, django_init_worker=ParallelTestSuite.init_worker) |
There was a problem hiding this comment.
Missing import for partial from functools. This will cause a NameError at runtime.
gregorjerse
force-pushed
the
feature/django_6
branch
from
ac3bf72 to
8752230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.