use Giuseppe's forked newuidmap/newgidmap#171
Merged
Conversation
Applies shadow-maint/shadow#132 so that we don't need to have CAP_SYS_ADMIN. See also genuinetools#170 . Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
AkihiroSuda
commented
Oct 9, 2018
| RUN apk add --no-cache autoconf automake build-base byacc gettext gettext-dev gcc git libcap-dev libtool libxslt | ||
| RUN git clone https://github.com/giuseppe/shadow.git \ | ||
| && cd shadow \ | ||
| && git checkout 336cead97d87be6c4828521f50a992e76a17e442 \ |
Collaborator
Author
There was a problem hiding this comment.
@giuseppe could you pin this commit on your repo? 🙏
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Collaborator
|
Thanks so much! I should just remove codacity |
AkihiroSuda
commented
May 8, 2019
| # As of v3.8.1, Alpine does not set SUID bit on the busybox version of /bin/su. | ||
| # However, future version may set SUID bit on /bin/su. | ||
| # We lock the root account so as to disable su completely. | ||
| RUN passwd -l root |
Collaborator
Author
There was a problem hiding this comment.
lol the unlocked root turned out to be an actually CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-5021
img is not affected since this passwd -l commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies shadow-maint/shadow#132 so that we
don't need to have CAP_SYS_ADMIN.
See also #170 .
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp