Skip to content

Conversation

@romaricdrigon
Copy link
Contributor

Hello,

Following #217, the Address annotation can now be used over a method (a getter).
The method must be public, and it can has any name / any return type.
It can't have required arguments, though, otherwise an exception will be thrown to indicate the annotation is erroneously used.

No BC breaks, some documentation was added.

@norkunas
Copy link
Member

Hey @romaricdrigon, could we also support using a setter? This should be possible using symfony/property-access unless you'd have another solution.

@romaricdrigon
Copy link
Contributor Author

Hello @norkunas,

I checked, I kept the old GeocodeListener code, which is writing latitude and longitude to the entity properties through reflection. So no need for Symfony PropertyAccess component. And actually, using PropertyAccess in the listener (which would require setters), would be a BC break.

My tests, which were using public properties, were a little bit misleading. I changed that.

I believe it should be all fine now!

@norkunas norkunas merged commit c9e152b into geocoder-php:master Aug 12, 2019
@norkunas
Copy link
Member

Thank you @romaricdrigon 🙂

@romaricdrigon
Copy link
Contributor Author

You are welcome, thank you for this bundle :)

@romaricdrigon romaricdrigon deleted the feat-217 branch August 12, 2019 06:28
@acrobat
Copy link
Contributor

acrobat commented Aug 19, 2019

@norkunas can we get a new release with this feature? Or is there work on other issues/features needed?

@norkunas
Copy link
Member

@acrobat I'm waiting other PR's to be merged and then will make a release.

@acrobat
Copy link
Contributor

acrobat commented Aug 22, 2019

@norkunas good! Anything I can do to help?

@norkunas
Copy link
Member

@acrobat 5.6.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants