Add withText and withCoordinates. #743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍 |
Member
Author
|
Thank you for the review. |
arubacao
reviewed
Jul 17, 2017
Contributor
arubacao
left a comment
arubacao
left a comment
There was a problem hiding this comment.
typo in test. should be text
| * @param string $text | ||
| * | ||
| * @return GeocodeQuery | ||
| */ |
Contributor
There was a problem hiding this comment.
there is a typo. test instead of text
Merged
mbrodala
added a commit
to mbrodala/Geocoder
that referenced
this pull request
Mar 2, 2018
This was missing in geocoder-php#743 and is essential for mocking in tests.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorators or plugins may want to rewrite the query somehow. This PR allows that.