fix(ui): notification clicks land on the right tab#384
Merged
Conversation
Two of the dashboard's push notifications carried URLs the router couldn't resolve. The dump notification used #dumps, which isn't a top-level tab, so parseHash silently fell back to dashboard and the click did nothing useful. The worker_failed notification used #sites/<name>, but the Sites tab is keyed by primary domain, so on any site where name and domain differ (whitewaters with theregistry.test, for example) the click landed on an empty state. Both now route through a small siteDomainForRoute helper that resolves a registered site name to its primary domain at notification build time, falling back to the input verbatim when no site matches (covers test fixtures and races between unlink and a late notification). The dump notification now points at #sites/<domain>/dumps; the Sites detail picks up an optional sub-tab segment from routeRest and switches SiteDetail to the matching internal tab on mount. The worker_failed URL becomes #sites/<domain>. SitesDetail now splits routeRest on / and uses the first segment as the domain selector instead of comparing the whole rest verbatim, so URLs with sub-segments still find their site. SiteDetail gains a $effect that watches the second segment of routeRest and overrides the localStorage-restored tab when the segment names a known sub-tab.
Merged
geodro
added a commit
that referenced
this pull request
May 19, 2026
The 1.21.0 line graduates from beta with eight follow-up commits on top of v1.21.0-beta.1. A LAN-exposure audit closes three dashboard endpoints that were reachable on lan:expose installs (raw .env, push-test, an unauthenticated mailpit webhook) and adds path-traversal validation for the new public_dir override (#382). mysql and mariadb pick up catatonit as PID 1 via a new init flag on the preset schema, so podman stop returns in around a second instead of timing out at 30s and lerd service restart stops wedging at the 30-90s mark (#383, closes #380). Host workers stopped via the UI or lerd worker stop no longer resurrect on the next fsnotify event or launchd heal tick, and the same fix puts lerd's bin directory on PATH for npm-spawned subprocesses so wayfinder and friends can find php (#375, #376, closes #381). The PHP-FPM runtime stage gets git back after the multi-stage split in #364 dropped it (#377), restoring VCS-typed composer repositories. Notification clicks land on the right tab now: worker_failed deep-links via the site's primary domain and dump arrivals jump straight to the Dumps sub-tab (#384). The .lerd.yaml container block accepts a target field for multi-stage Containerfiles, with the cache key mixing target in so flipping stages on an unchanged file actually rebuilds (#385, addresses #379), and the MCP service_add tool picks up the matching init argument so agent-driven flows reach feature parity with the YAML path (#386). And a security pass bumps jwt-go to 5.2.2, svelte to 5.55.8, and kysely to 0.28.17 closing one high-severity JWT header-parsing flaw, three medium svelte XSS paths, and one high kysely JSON-path traversal injection (#387).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the dashboard's push notifications carried URLs the router couldn't resolve. The
dumpnotification used#dumps, which isn't a top-level tab, soparseHashsilently fell back to dashboard and the click did nothing useful. Theworker_failednotification used#sites/<name>, but the Sites tab is keyed by primary domain, so on any site where name and domain differ (whitewaters with theregistry.test, for example) the click landed on an empty state.Both now route through a small
siteDomainForRoutehelper that resolves a registered site name to its primary domain at notification build time, falling back to the input verbatim when no site matches (covers test fixtures and races between unlink and a late notification). The dump notification now points at#sites/<domain>/dumpsandSiteDetailswitches to the dumps sub-tab on mount when the second segment is set. The worker_failed URL becomes#sites/<domain>so the existing detail-by-domain match works.SitesDetailnow splitsrouteReston/and uses the first segment as the domain selector instead of comparing the whole rest verbatim, so URLs with sub-segments still find their site.SiteDetailgains a$effectthat watches the second segment ofrouteRestand overrides the localStorage-restored tab when the segment names a known sub-tab.