Enable ASAN on CI and fix a null-termination bug#246
Merged
Conversation
2 tasks
Member
|
I'm happy for this to merge – I don't know a huge amount about ASAN but the setup seems reasonable:
And the fix itself seems good – we already do something similar in (A small nit: please squash these commits before we merge) @weiznich @lnicola @michaelkirk does anyone else want to weigh in? |
urschrei
approved these changes
Feb 1, 2026
yutannihilation
force-pushed
the
ci/sanitizer
branch
from
6839daf to
5a64d7a
Compare
yutannihilation
changed the title
Contributor
Author
|
Thanks, I squashed the commits. |
weiznich
approved these changes
Feb 2, 2026
Contributor
weiznich
left a comment
weiznich
left a comment
There was a problem hiding this comment.
It's reasonable to apply asan this way. That's what I also do for other projects so 👍 from me
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
- [x] I agree to follow the project's [code of conduct](https://github.com/georust/.github/blob/main/CODE_OF_CONDUCT.md). - [x] I added an entry to the project's change log file if knowledge of this change could be valuable to users. - Usually called `CHANGES.md` or `CHANGELOG.md` - Prefix changelog entries for breaking changes with "BREAKING: " --- Follow up to #246 LLM was used to help with docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES.mdorCHANGELOG.mdDuring investigating the Windows build, I found there's a memory corruption bug. This pull request is to prove it is a real bug in other OSes than Windows as well. Note that I'm not an expert of ASAN (and C++ in general), so I'm not sure if these compiler flags are exactly the best for our purpose.
This is the result when I ran this on my forked repo:
https://github.com/yutannihilation/proj/actions/runs/21554286154/job/62107945847#step:5:129
I also confirmed 1c9bc45 fixes this error.