You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@scivision, the pull request is ready.
Is it possible to activate for this repository pre-commit ci and Codecov and then approve the workflows to check if it works?
@scivision,
I rebased the branch, all CI is passing.
Can activate pre-commit ci? pre-commit run --all-files pass locally on my machine.
It replaces flake8 and mypy in the CI and adds much more.
Also, why did you deactivate the coverage with full dependencies?
It reduces the test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Code Quality
Improve typing
mypystrict modepy.typedto enable typing (c.f. Would adding py.typed suffice to add mypy support ? #73, PEP 561 compliant)pre-commit
ruffconfiguration for the new releaseBadges
Add some badges,
Contributing
CONTRIBUTING.mdfile to standardise how to set uppymap3dto contributepre-commitCI