Optional ineternal monaco-editor loading #268
Open
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… newly added NEXT_PUBLIC_LOAD_MONACO_INTERNALLY env variable
…elf-hosting README file, and to the docker-compose file.
Collaborator
|
Fixes #263 adding @Nicolapps for review. |
Author
|
@nipunn1313 Hey, can this PR be reviewed? Or should I just maintain my own fork? |
Collaborator
|
we're debating about whether it's worth the bloat. I think for now - keep maintaining your fork - as we're probably leaning towards maintaining the status quo and keeping the bloat down for the package. Might change our minds in the future, but for now, we'll just leave it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optional configuration for the self-hosted dashboard, controllerd by the
NEXT_PUBLIC_LOAD_MONACO_INTERNALLYenvironment variable, that allows to load the monaco-editor as a npm package, instaed of the default CDN loader.This really helpful in cases of network limted deployments that do not have access to the public cdn.jsdeliver.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.