Please fix this line to use the appropriate EAP method and catch errors when PEAP is used

[spaetow]

Hi folks,

We note that geteduroam hard-codes EAP-TTLS when either EAP-TTLS or PEAP are found. While I appreciate that Android currently only accepts EAP-TTLS, EAP-TLS or EAP-AKA/AKA', it is possible that Android will possibly fix the ability to use PEAP as a method for Passpoint (we can but hope).

So, in line 297 of the PlatformWifiConfigData file, you hard-code EAP-TTLS when either EAP-TTLS or PEAP is found. Please fix this to use the correct EAP type.

android-app/android/app/src/main/java/app/eduroam/geteduroam/config/PlatformWifiConfigData.kt

Line 297 in 08a39b5

us.eapType = 21 // 21 indicates TTLS (RFC 5281)

HOWEVER - When PEAP is found, there should probably a wrapper around the call to the API setting the profile (see below):

android-app/android/app/src/main/java/app/eduroam/geteduroam/config/WifiConfigViewModel.kt

Lines 235 to 237 in 08a39b5

	passpointConfig?.install(context)
	} catch (e: IllegalArgumentException) {
	// Can throw when configuration is wrong or device does not support Passpoint

So that when that IllegalArgument exception is thrown, you can gracefully recover and log (in debug, and probably show a warning in the UI maybe) that the EAP type PEAP was not accepted by Android. That way, if suddenly Android fixes the problem, the exception no longer occurs and the profile is created.

Does that make sense?

[spaetow]

Just to add, this has been raised in the Wireless Broadband Alliance as an issue, and this is being passed on to Google to solve ASAP, so we may see changes in Android's behaviour and this should be considered for fixing in anticipation of that.