Fix for TransactionTooBig crashes due to passing Base64 encoded logos#151
Merged
Fix for TransactionTooBig crashes due to passing Base64 encoded logos#151
Conversation
Added logging to track data sizes in: - EAPIdentityProviderListNavType (serialization/deserialization) - WifiConfigViewModel (receiving data via navigation) - SelectProfileViewModel (storing EAPIdentityProviderList in UI state) Fix TransactionTooLargeException by removing logos from SavedState Solution overview: - Store provider logos separately from SavedStateHandle - Strip logos from EAPIdentityProviderList before navigation - Keep logos visible on SelectProfileScreen via separate property
dzolnai
approved these changes
Oct 15, 2025
Just one thing to say is that this should probably be fed back to the CAT folks, because massive logos shouldn't be in the profile file in the first place. They should be sized down by the organisation who owns the profile, or the CAT system itself. I'll raise a CAT issue on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the logic for how provider logos are passed between screens. The current implementation was causing TransactionTooBig crashes when the UiState was stored or retrieved in certain scenarios. By keeping the actual Bitmap in memory instead of passing huge Base64 string transactions are down to a few KB rather than several MB in some cases.