Support for script dependencies

[csrui]

Implements script dependencies through the use:

$enqueue->front([
    'as'     => 'ShirtCreatorInterface',
    'src'    => Helper::assetUrl('/js/app.js'),
    'dep'   => ['jquery'],
    'filter' => [ 'page' => '*' ]
]);

[ConnorVG]

This makes sense to me. Though, you should allow dep to be passed a string if there is only one of them, for sure 😄

[ConnorVG]

I'd either new line this and use curlies or, on L77 use array_get($attrs, 'dep', []) instead.

[csrui]

Most definitely a worthy improvement. Will take care of that.

[csrui]

Not sure if I should have created a new branch but since the source code affects the same area...

[JacobDorman]

+1

[PrafullaKumarSahu]

@csrui I have just started learning herbert from nearly a month and I do feel like a looser, as I am unable to do things usually I can do in wordpress, in last one month, using even your code

public function __construct(Enqueue $enqueue){
        $this->enqueue = $enqueue;
    }


    $this->enqueue->front([
            'as' => 'analytica',
            'src' => Helper::assetUrl('/jquery/analytica.js'),
            'dep' => ['jquery'],
            'filter' => [ 'page' => '*' ]
        ]);

It gives me error Fatal error: Using $this when not in object context in E:\plugins\Analytica\app\Controllers\AnalyticaController.php on line 168

and if I will call front with Enqueue::fronT() , it gives me no error neither it enqueue the script.

[tormjens]

Hi @PrafullaKumarSahu

You need can't use $this directly in a class without having it in a method.

Move your code up to the __construct-method, should work.

public function __construct(Enqueue $enqueue){
        $this->enqueue = $enqueue;

        $this->enqueue->front([
            'as' => 'analytica',
            'src' => Helper::assetUrl('/jquery/analytica.js'),
            'dep' => ['jquery'],
            'filter' => [ 'page' => '*' ]
        ]);
}

[PrafullaKumarSahu]

Hi @tormjens I have already solved this issue by en-queuing my scripts in enqueue.php
like below, any way thank you for your effort.

<?php namespace Analytica;

/** @var \Herbert\Framework\Enqueue $enqueue */

$enqueue->admin([
    'as'     => 'jquery',
    'src'    => 'jquery',
    'filter' => [ 'panel' => 'analytica-admin-settings' ]
]);

$enqueue->admin([
    'as'  => 'popup',
    'src' => Helper::assetUrl('/jquery/popup.js'), // => /resources/assets/js/popup.js
], 'footer');

$enqueue->admin([
    'as'  => 'analytica',
    'src' => Helper::assetUrl('/jquery/analytica.js'), // => /resources/assets/js/analytica.js
    'filter' => ['panel'=>'analytica-admin-settings']

], 'footer');

$enqueue->admin([
    'as'     => 'jquery-ui-datepicker',
    'src'    => 'jquery-ui-datepicker',
    'filter' => [ 'panel' => 'analytica-admin-settings' ]
], 'footer');

$enqueue->admin([
    'as'     => 'jquery-ui-datepicker',
    'src'    => 'http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/themes/base/jquery-ui.css',
    'filter' => [ 'panel' => 'analytica-admin-settings' ]
]);

$enqueue->admin([
    'as'     => 'datepicker',
    'src'    => Helper::assetUrl('/jquery/datepicker.js'),
    'filter' => [ 'panel' => 'analytica-admin-settings' ]
], 'footer');

[jeremyzahner]

@onnimonni This feature is crucial. Since the commits look firm, I see no reason for further delaying a merge.

[jeremyzahner]

@csrui Could you resolve the merge conflicts? Thanks!

[jeremyzahner]

@csrui Ping. =)

[csrui]

This project seems dead.