Draft
Conversation
Contributor
Author
|
TODO:
|
Contributor
Author
|
I added a couple of translation strings to assets/locales/en-us.po. What's the process for getting those translated @Derekf5? |
Contributor
Author
|
This just needs some translations |
Contributor
Author
|
Oh and we need to merge the related flashlight branch... |
Contributor
Contributor
|
Hey @greySkiesMarsh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new "proxyless" feature across multiple components of the application. Key changes include backend logic to manage proxyless settings, UI updates to expose the feature in the settings, and necessary updates to the session model. Additionally, minor improvements and fixes were made to existing code.
Proxyless Feature Implementation:
Backend support for proxyless settings:
pathProxylessininternalsdk/session_model.goto define the proxyless path.setProxylessandProxylessEnabledmethods inSessionModelto handle proxyless state management. [1] [2] [3]UI integration for proxyless toggle:
lib/features/account/settings.dart, including aCupertinoSwitchfor toggling the proxyless state.lib/common/ui/image_paths.dart.Session model updates:
proxylessNotifierand corresponding methods tolib/features/home/session_model.dartfor managing proxyless state in the app. [1] [2] [3]Minor Improvements and Fixes:
Improved directory creation in
hit_proxy.bash:mkdir -pwithmkdir -pvfor verbose output and added error handling when fetching proxy configuration.UI consistency updates:
lib/features/account/settings.dartfor better formatting. [1] [2]CupertinoSwitchproperty name inlib/features/account/split_tunneling.dart.