Harden stage environment toggle and env normalization by atavism · Pull Request #8475 · getlantern/lantern

atavism · 2026-02-17T18:03:19Z

Rebases stage-env follow-ups on the latest jigar/stage-env, normalizes env values to stage/prod and avoids clearing data on env toggle

* Hide onboarding page and datacap in ios and update build number * code review updates

* pull in radiance changes

* update design size for tablets * add cap scaling * update mintextadapt * logo updates and clean-ups * update text fields * clean-ups * clean-ups * fix scaling issue --------- Co-authored-by: Jigar-f <jigar@getlantern.org>

* add support for internal Android releases * use correct name for internal track * update r0adkll/upload-google-play * Fix track name * update versionCode * update foreground service permission * disable exact alarm

Copilot

Pull request overview

This PR hardens environment handling (stage vs prod) in-app and modernizes the release pipeline to support multiple build types (production/beta/internal/nightly), including consistent versioning, artifact naming, and publishing.

Changes:

Normalize persisted environment values to stage/prod and avoid destructive data-directory clearing on env toggle.
Rework GitHub Actions release automation: centralized metadata/version generation, draft release creation/finalization, artifact uploads to S3 + GitHub Release, and appcast updates (plus removal of the separate nightly workflow).
UI/UX adjustments for safe areas and tablet scaling caps; Android VPN service hardening for TUN fd lifecycle.

Reviewed changes

Copilot reviewed 31 out of 31 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
scripts/generate_appcast.py	Adds `BUILD_TYPE` handling for production vs beta appcast generation.
scripts/ci/version.sh	New helper to validate/extract/generate versions for build types.
scripts/ci/publish-to-s3.sh	New script to upload per-platform artifacts to versioned + `latest` S3 paths.
scripts/ci/format.sh	New formatter for release notes, job summary, and Slack payloads.
pubspec.yaml	Increments build number.
lib/main.dart	Removes commented-out timezone code.
lib/lantern_app.dart	Uses `designSizeFor(context)` for ScreenUtil design size.
lib/lantern/lantern_ffi_service.dart	Normalizes Radiance env to `stage`/`prod`.
lib/features/plans/plans.dart	Wraps body in `SafeArea`.
lib/features/onboarding/onboarding.dart	Adjusts onboarding flow to skip slide 3 on iOS.
lib/features/home/provider/app_setting_notifier.dart	Normalizes env values and changes staging toggle behavior to a marker-file approach.
lib/features/home/home.dart	Hides data usage widget on iOS in one branch.
lib/features/developer/developer_mode.dart	Treats `stage` and legacy `staging` as staging; awaits env switch then shows restart dialog.
lib/core/widgets/lantern_logo.dart	Caps logo sizing using MediaQuery width (tablet-friendly).
lib/core/models/entity/app_setting_entity.dart	Defaults environment to `prod`.
lib/core/common/cap_scaling.dart	New capped scaling helpers (sp/h).
lib/core/common/app_text_field.dart	Uses capped scaling for font sizes and centers text vertically.
lib/core/common/app_dimens.dart	Adds `designSizeFor(context)` and tablet sizing behavior.
lib/core/common/app_buttons.dart	Uses capped scaling for font/icon sizing and refactors button style helpers.
ios/Runner.xcodeproj/project.pbxproj	Removes simulator arch exclusion.
android/app/src/main/kotlin/.../LanternVpnService.kt	Adds synchronized TUN fd close to prevent races/orphaned TUN.
android/app/src/main/AndroidManifest.xml	Changes foreground service permission/type and comments out exact alarm permission.
android/app/build.gradle	Changes Android `versionCode` computation.
Makefile	Installer naming now omits `-production` suffix; adds iOS installer naming.
.github/workflows/release.yml	Major release workflow overhaul: schedule/manual builds, draft release create/finalize, S3/GH uploads, appcast update, Play/TestFlight steps.
.github/workflows/nightly.yml	Removes separate nightly workflow.
.github/workflows/build-windows.yml	Switches to `installer_base_name` and updates artifact naming; adds caching.
.github/workflows/build-macos.yml	Switches to `installer_base_name`, adds caching (Go/gomobile/Flutter) and env wiring.
.github/workflows/build-linux.yml	Switches to `installer_base_name`, adds caching and env wiring.
.github/workflows/build-ios.yml	Switches to `installer_base_name`, adds caching (Go/gomobile/Flutter) and env wiring.
.github/workflows/build-android.yml	Switches to `installer_base_name`, adds caching (gomobile) and env wiring.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/app/build.gradle

.github/workflows/release.yml

scripts/generate_appcast.py

lib/core/common/cap_scaling.dart

jigar-f · 2026-02-18T05:55:53Z

lib/features/home/provider/app_setting_notifier.dart

+    final markerFile = File('${dir.path}/.radiance_env');

-    // Delete and recreate the directory
-    if (dir.existsSync()) {


@atavism Why were these changes removed? Any reason? This is the change actually needed to make staging work.

* work for stage env * update var name * use output var * set output * Update nightly.yml * try to use as env variable * Update build-macos.yml * update name * Remove stage for now & add default value * keep default and pass value * Simplify macos changes * Remove stage again * More debugging * compare it as string * added debug log * update radiance. * updated radiance * update radiance * use remote source * more stage changes * use radiance remote * Add stage env connection. * Revert workflows * generate ffi * use radiance remote and remove duplication logic * ran make format * use in app purchase for macos. * back to storekit one. * Switch to user on acknowledge purchase if found. * use new radiance. * update radiance. * do not clear all data * Harden stage environment toggle and env normalization (#8475) * Hide onboarding and datacap in ios (#8466) * Hide onboarding page and datacap in ios and update build number * code review updates * Garmr/ipc auth update (#8468) * pull in radiance changes * remove exclude arch in debug mode * Update to latest radiance with no DNSTT since its breaking stuff (#8470) * build and release updates (#8455) * add safe area in plans * Fix tablet upscaling and cap shared component sizing (#8457) * update design size for tablets * add cap scaling * update mintextadapt * logo updates and clean-ups * update text fields * clean-ups * clean-ups * fix scaling issue --------- Co-authored-by: Jigar-f <jigar@getlantern.org> * Fix for closing TUN (#8471) * Fix stage env toggle and store gating * Narrow followups to staging env * Enable Play store uploads for internal Android releases (#8467) * add support for internal Android releases * use correct name for internal track * update r0adkll/upload-google-play * Fix track name * update versionCode * update foreground service permission * disable exact alarm --------- Co-authored-by: jigar-f <132374182+jigar-f@users.noreply.github.com> Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com> Co-authored-by: Jigar-f <jigar@getlantern.org> Co-authored-by: Myles Horton <afisk@getlantern.org> Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com> * Revert back some changes * Fix issue with stage * Fix stage issue on windows * update logs * revert back macos in app purchase changes --------- Co-authored-by: atavism <atavism@users.noreply.github.com> Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com> Co-authored-by: Myles Horton <afisk@getlantern.org> Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com> Co-authored-by: atavism <paul@getlantern.org>

jigar-f and others added 12 commits February 12, 2026 19:59

Hide onboarding and datacap in ios (#8466)

4354333

* Hide onboarding page and datacap in ios and update build number * code review updates

Garmr/ipc auth update (#8468)

2735f53

* pull in radiance changes

remove exclude arch in debug mode

2e430b2

Update to latest radiance with no DNSTT since its breaking stuff (#8470)

30cb4b4

build and release updates (#8455)

5b5f80c

add safe area in plans

9446aa3

Fix tablet upscaling and cap shared component sizing (#8457)

f1a2f79

* update design size for tablets * add cap scaling * update mintextadapt * logo updates and clean-ups * update text fields * clean-ups * clean-ups * fix scaling issue --------- Co-authored-by: Jigar-f <jigar@getlantern.org>

Fix for closing TUN (#8471)

2f70af4

Fix stage env toggle and store gating

2aa833d

Narrow followups to staging env

3792af6

Enable Play store uploads for internal Android releases (#8467)

904049d

* add support for internal Android releases * use correct name for internal track * update r0adkll/upload-google-play * Fix track name * update versionCode * update foreground service permission * disable exact alarm

Merge main into stage env followups

9b235ab

atavism requested a review from Copilot February 17, 2026 18:03

Copilot started reviewing on behalf of atavism February 17, 2026 18:03 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

android/app/build.gradle Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

.github/workflows/release.yml Show resolved Hide resolved

scripts/generate_appcast.py Show resolved Hide resolved

lib/core/common/cap_scaling.dart Show resolved Hide resolved

atavism merged commit d28d9cf into jigar/stage-env Feb 17, 2026
6 checks passed

atavism deleted the atavism/stage-env-followups branch February 17, 2026 18:20

jigar-f reviewed Feb 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Harden stage environment toggle and env normalization#8475

Harden stage environment toggle and env normalization#8475
atavism merged 12 commits intojigar/stage-envfrom
atavism/stage-env-followups

atavism commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jigar-f Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Comments

Conversation

atavism commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jigar-f Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants