This repository was archived by the owner on Mar 23, 2025. It is now read-only.
Allow config defaults to be sourced from ENV#314
Merged
hkalexling merged 5 commits intogetmango:devfrom Jul 3, 2022
Merged
Conversation
This allows the default config to source values from ENV variables if they are set. With this change we don't have to modify the docker CMD or edit the config.yml and then relaunch.
crainte
force-pushed
the
feature/default-env-vars
branch
4 times, most recently
from
beb3714 to
8817f71
Compare
crainte
force-pushed
the
feature/default-env-vars
branch
from
d6a3200 to
d6c3a33
Compare
This allows the default config to source values from ENV variables if they are set. With this change we don't have to modify the docker CMD or edit the config.yml and then relaunch.
crainte
force-pushed
the
feature/default-env-vars
branch
from
d6c3a33 to
f3eb62a
Compare
…/Mango into feature/default-env-vars
Member
|
Hey thanks for the PR! I like the idea, and I refactored it with macro to enforce DRY. Note that now the environment variable names are just upper-case version of the Crystal variable names, so you might want to change some of the keys if you are actively using the old implementation. |
hkalexling
approved these changes
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if you're interested in this, but it made running Mango much easier on my local install.
This allows the default config to source values from ENV variables if they are set. With this change we don't have to modify the docker CMD or edit the config.yml and then relaunch.