Escape HTML characters before rendering in results table, fixes #755#1111
Closed
James226 wants to merge 1 commit intogetredash:masterfrom
Closed
Escape HTML characters before rendering in results table, fixes #755#1111James226 wants to merge 1 commit intogetredash:masterfrom
James226 wants to merge 1 commit intogetredash:masterfrom
Conversation
Member
|
Although it's crude, allowing some HTML in table results is a feature to enable creating drill downs and other useful things. This pull request breaks it. The ideal way will be to allow the user to decide if he wants to render HTML in the table row or not. This will happen when we implement options for the table visualization. For now to prevent breaking existing functionality, I will have to pass on this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve HTML/XML being rendered in table results.