Firefox: widget height continuously increases#2452
Merged
arikfr merged 1 commit intogetredash:masterfrom Apr 11, 2018
kravets-levko:bug/firefox-widget-height-continuously-increases
Merged
Firefox: widget height continuously increases#2452arikfr merged 1 commit intogetredash:masterfrom kravets-levko:bug/firefox-widget-height-continuously-increases
arikfr merged 1 commit intogetredash:masterfrom
kravets-levko:bug/firefox-widget-height-continuously-increases
Conversation
…and widget has params, but possibly other cases) widget start continuously growing
Member
|
Did you check this one on Chrome? 🤣 |
Collaborator
Author
|
Yes, of course 😎 |
kravets-levko
deleted the
bug/firefox-widget-height-continuously-increases
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox, dashboard, auto-height feature: in some cases (loader shown and widget has params, but possibly other cases) widget starts continuously growing. Why: Firefox uses different rounding strategy for element's dimensions (
offsetHeightis always integer (rounded up),getBoundingClientRectreturns dimensions with a "garbage", i.e. if element has height100.45px, it will return something like100.45006791123px, but in fact will use only few fraction digits). Fix: explicitly round values before computing widget height.