add copy dashboard page feature#5232
add copy dashboard page feature#5232gaecoli wants to merge 1 commit intogetredash:masterfrom gaecoli:add-copy-dashboard-feature
Conversation
kravets-levko
left a comment
kravets-levko
left a comment
There was a problem hiding this comment.
Hi @yankeeguyu! Thank you for your contribution, that's really a cool feature 🎉 Please see my comments
There was a problem hiding this comment.
Please refer to the similar function we have for queries. It's implemented in a bit cumbersome way not because we were high, but because that was the only way to make it reliable. E.g. if you'll try to open a popup in some async handler (like here) - 50/50 browser will block it, because JS can show popups only as a response to user interaction. Also it's important to disable menu item while action is in progress. And so on.
There was a problem hiding this comment.
@yankeeguyu Please address this one too. Use this for the reference: https://github.com/getredash/redash/blob/83726da48a0d1768a8f726f007ce0c6fd594c2de/client/app/pages/queries/hooks/useDuplicateQuery.js
There was a problem hiding this comment.
Sorry, i am going to modify this later!
There was a problem hiding this comment.
@yankeeguyu Please address this one too. Use this for the reference: https://github.com/getredash/redash/blob/83726da48a0d1768a8f726f007ce0c6fd594c2de/client/app/pages/queries/hooks/useDuplicateQuery.js
Hi @kravets-levko , i modified this comment, but it can't work! So someone can help me? Thank you!
|
Hi @kravets-levko , i addressed all comments! Please check this PR, thank you! |
|
Replaced with #5274 |
2 participants
What type of PR is this? (check all applicable)
Description
This PR is feature of copy dashboard page with widgets!