LDAP authentication improvement according to https://github.com/getredash/redash/pull/2776#115
Open
MrCirca wants to merge 6 commits intogetredash:masterfrom
Open
LDAP authentication improvement according to https://github.com/getredash/redash/pull/2776#115MrCirca wants to merge 6 commits intogetredash:masterfrom
MrCirca wants to merge 6 commits intogetredash:masterfrom
Conversation
Author
|
The PR #115 for this doc has been merged. Please check this PR. |
Member
|
Thanks, but you need to rebase this. It might be easier for you to create a new branch based on latest master and update the new file. |
Author
|
Check now |
arikfr
requested changes
Mar 11, 2019
Member
arikfr
left a comment
There was a problem hiding this comment.
You need to update this file: src/pages/kb/open-source/admin-guide/ldap-authentication.md.
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
According to pull_request, i have improved the documentation of ldap-authentication