Skip to content

LDAP authentication improvement according to https://github.com/getredash/redash/pull/2776#115

Open
MrCirca wants to merge 6 commits intogetredash:masterfrom
MrCirca:master
Open

LDAP authentication improvement according to https://github.com/getredash/redash/pull/2776#115
MrCirca wants to merge 6 commits intogetredash:masterfrom
MrCirca:master

Conversation

@MrCirca
Copy link
Copy Markdown

@MrCirca MrCirca commented Sep 20, 2018

Hello,
According to pull_request, i have improved the documentation of ldap-authentication

@MrCirca
Copy link
Copy Markdown
Author

MrCirca commented Mar 1, 2019

The PR #115 for this doc has been merged. Please check this PR.
Thank you!

@arikfr
Copy link
Copy Markdown
Member

arikfr commented Mar 10, 2019

Thanks, but you need to rebase this. It might be easier for you to create a new branch based on latest master and update the new file.

@ghost ghost added the in progress label Mar 10, 2019
@MrCirca
Copy link
Copy Markdown
Author

MrCirca commented Mar 10, 2019

Check now

Copy link
Copy Markdown
Member

@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update this file: src/pages/kb/open-source/admin-guide/ldap-authentication.md.

@MrCirca
Copy link
Copy Markdown
Author

MrCirca commented Mar 14, 2019

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants