Conversation
Contributor
Author
|
@billyvg Hi, Can you review this? |
Member
|
@whywaita Ah sorry, this got lost, will take a look now, thanks |
billyvg
reviewed
Aug 23, 2021
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Left a note, but otherwise this looks good. Thanks!
Comment on lines
+1
to
+4
| import { createAppAuth } from "@octokit/auth-app"; | ||
| import { Octokit } from "@octokit/rest"; | ||
| import { Endpoints } from "@octokit/types"; | ||
| import * as core from "@actions/core"; |
Member
There was a problem hiding this comment.
Oops, I guess I didn't run pre-commit hooks when I committed this 🙊🙊 - thanks!
src/main.ts
Outdated
| }); | ||
|
|
||
| const {data} = await appOctokit.apps.listInstallations(); | ||
| type listInstallationsResponse = Endpoints["GET /app/installations"]["response"]; |
Member
There was a problem hiding this comment.
Can you move this type alias out of the function? I think it's a bit confusing to have type aliases mixed inside of runtime code.
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added
scopeto actions input.appOctokit.apps.listInstallations()response array of installation. This array has multiple contents when installed to multi-organization or repositories.So
scopeis a filter for an array of installation.scopeinputs often the organization name or the repository name.