feat(metrics): Add a metric for total number of available processes #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Oct 28, 2025
fpacifici
reviewed
Oct 28, 2025
Comment on lines
605
to
616
| self.__metrics.gauge( | ||
| "arroyo.strategies.run_task_with_multiprocessing.processes", num_processes | ||
| ) | ||
| self.__metrics.gauge( | ||
| "arroyo.strategies.run_task_with_multiprocessing.pool_size", num_processes | ||
| ) |
Contributor
There was a problem hiding this comment.
These two are redundant.
Please keep only one. Also you do not need to record the metric here. Only below when you record the processes in use.
evanh
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record total number of available processes in the
arroyo.strategies.run_task_with_multiprocessing.processesmetric in__submit_batchalongside__batches_in_progressin order to be able to calculate utilization.Refs STREAM-488