feat(consumer): add flag to retry on handle detroyed #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Nov 6, 2025
Member
untitaker
left a comment
untitaker
left a comment
There was a problem hiding this comment.
please revert the formatting changes using black on the CLI, otherwise lgtm. i don't think a test is needed
bmckerry
force-pushed
the
ben/retry-broker-handle
branch
from
b716a6c to
f0a9137
Compare
untitaker
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option to consumers to retry during commit on the
KafkaError._DESTROYerror, which we've seen happen if the consumer group coordinator changes during shutdown.Draft as I haven't added a test for this yet.