ref(rust): Simplify metrics interface (breaking change) #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metrics interface in rust-arroyo was inherited from merni and has support for value-less (or key-less) metric tags. Those are not used in arroyo, so we can simplify the interface. We can also guarantee that keys are not dynamically generated, saving us one trait object. This will make it easier to interface with the metrics crate in the streams repo, which does not support value-only tags.
bmckerry
approved these changes
Dec 8, 2025
Member
bmckerry
left a comment
bmckerry
left a comment
There was a problem hiding this comment.
I know what the PR aims to do and this looks right but I am not qualified to review a macro change
evanh
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics interface in rust-arroyo was inherited from merni and has
support for value-less (or key-less) metric tags. Those are not used in
arroyo, so we can simplify the interface. We can also guarantee that
keys are not dynamically generated, saving us one trait object.
This will make it easier to interface with the metrics crate in the
streams repo, which does not support value-only tags.