docs: Update base path for cli.sentry.dev domain#100
Merged
Conversation
The docs site has moved from getsentry.github.io/cli to cli.sentry.dev. This caused assets to fail loading as they were still being served from /cli/. Changes: - Change default base path from /cli to / - Update site URL to https://cli.sentry.dev - Update landing page detection to work with root path - Add pages-base-url to preview workflow PR previews continue to work via DOCS_BASE_PATH environment variable override.
Contributor
|
3 tasks
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Documentation 📚
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The docs site has moved from
getsentry.github.io/clitocli.sentry.dev. This caused assets to fail loading as they were still being served from/cli/.Changes
/clito/https://cli.sentry.devpages-base-urlto preview workflowPR previews continue to work via
DOCS_BASE_PATHenvironment variable override in the workflow.Based on getsentry/craft#734