Merged
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 2027 uncovered lines. Files with missing lines (27)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 68.30% 68.30% —%
==========================================
Files 55 55 —
Lines 6395 6395 —
Branches 0 0 —
==========================================
+ Hits 4368 4368 —
- Misses 2027 2027 —
- Partials 0 0 —Generated by Codecov Action |
4a45717 to
13b0169
Compare
Add a boolean tag to Sentry telemetry to distinguish between SaaS and self-hosted Sentry instances. Also consolidates URL utilities: - Move isSentrySaasUrl to sentry-urls.ts (canonical location) - Remove duplicate DEFAULT_SENTRY_URL from sentry-urls.ts (use constants.ts) - Remove getDefaultBaseUrl and isSentrySaasUrl from region.ts (use sentry-urls.ts)
13b0169 to
03ae0cf
Compare
Member
Author
|
@sentry review |
Member
Author
|
@cursor review |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
is_self_hostedboolean tag to Sentry telemetry to distinguish between SaaS and self-hosted instances.Changes
is_self_hostedtag ininitSentry()based onSENTRY_URLconfigurationsentry-urls.ts:isSentrySaasUrlfromregion.tstosentry-urls.tsDEFAULT_SENTRY_HOSTfromconstants.ts(removes duplicate)getDefaultBaseUrlandisSentrySaasUrlfromregion.tsBehavior
is_self_hostedhttps://sentry.io)falsehttps://us.sentry.iofalsehttps://sentry.mycompany.comtrue