refactor(upgrade): use centralized user-agent for GitHub API requests#173
Merged
refactor(upgrade): use centralized user-agent for GitHub API requests#173
Conversation
Replace hardcoded 'sentry-cli' user-agent string with getUserAgent() from constants.ts, which generates proper version and runtime info (e.g., 'sentry-cli/0.5.0 (linux-x64) bun/1.3.3').
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 2184 uncovered lines. Files with missing lines (34)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 70.49% 70.49% —%
==========================================
Files 54 54 —
Lines 7400 7402 +2
Branches 0 0 —
==========================================
+ Hits 5216 5218 +2
- Misses 2184 2184 —
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace hardcoded
User-Agent: sentry-cliin the upgrade module with the centralizedgetUserAgent()function fromconstants.ts.This ensures GitHub API requests (for version checks and releases) use the same descriptive user-agent format as Sentry API requests:
Changes
getUserAgent()fromconstants.tsGITHUB_HEADERSconstant togetGitHubHeaders()functionfetchLatestFromGitHub()andversionExists()to use the new functionCloses: N/A
Cursor Bugbot reviewed your changes and found no issues for commit 6189f50