Skip to content

fix: address bugbot review comments on dsn-cache model-based tests#176

Merged
BYK merged 1 commit intomainfrom
fix/dsn-cache-model-based-tests
Feb 5, 2026
Merged

fix: address bugbot review comments on dsn-cache model-based tests#176
BYK merged 1 commit intomainfrom
fix/dsn-cache-model-based-tests

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 4, 2026

Summary

Addresses the review comments from Cursor Bugbot on PR #171.

Fixes

1. Invalid source value (Low Severity)

  • Changed "env-file" (hyphen) to "env_file" (underscore) to match the actual DsnSource type definition

2. Incomplete field verification (Low Severity)

  • Added orgName and projectName verification to GetCachedProjectCommand
  • Added orgName and projectName verification to GetCachedProjectByDsnKeyCommand
  • Now all 4 fields of the ResolvedInfo type are verified, matching the thoroughness of GetCachedDsnCommand

Verification

bun test test/lib/db/dsn-cache.model-based.test.ts
# 4 pass, 0 fail, 2024 expect() calls (up from ~1659)

The increased assertion count (2024 vs previous) confirms the additional field verifications are being executed.

Cursor Bugbot reviewed your changes and found no issues for commit 57767d3

- Fix source type: 'env-file' → 'env_file' to match DsnSource type
- Add orgName and projectName verification to GetCachedProjectCommand
- Add orgName and projectName verification to GetCachedProjectByDsnKeyCommand

Now verifies all 4 fields in project cache commands for complete coverage.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (dsn) Add project root detection for automatic DSN discovery by BYK in #159
  • (issue) Replace --org/--project flags with /ID syntax by BYK in #161
  • (lib) Add anyTrue helper for parallel-with-early-exit pattern by BYK in #174
  • (telemetry) Add withTracing helper to reduce Sentry span boilerplate by BYK in #172

Bug Fixes 🐛

  • (types) Align schema types with Sentry API by betegon in #169
  • Address bugbot review comments on dsn-cache model-based tests by BYK in #176
  • Added nullable in substatus's zod validation by MathurAditya724 in #157

Internal Changes 🔧

  • (upgrade) Use centralized user-agent for GitHub API requests by BYK in #173

Other

  • test: add model-based tests for DSN and project cache by BYK in #171
  • test: add model-based and property-based testing with fast-check by BYK in #166

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 2181 uncovered lines.
✅ Project coverage is 70.71%. Comparing base (base) to head (head).

Files with missing lines (34)
File Patch % Lines
human.ts 31.80% ⚠️ 684 Missing
resolve-target.ts 10.74% ⚠️ 291 Missing
oauth.ts 25.10% ⚠️ 194 Missing
upgrade.ts 40.23% ⚠️ 153 Missing
api-client.ts 74.21% ⚠️ 138 Missing
resolver.ts 3.23% ⚠️ 120 Missing
errors.ts 5.94% ⚠️ 95 Missing
migration.ts 47.44% ⚠️ 82 Missing
version-check.ts 34.04% ⚠️ 62 Missing
telemetry.ts 77.43% ⚠️ 51 Missing
api.ts 89.80% ⚠️ 47 Missing
seer.ts 75.54% ⚠️ 45 Missing
preload.ts 38.71% ⚠️ 38 Missing
seer.ts 79.87% ⚠️ 30 Missing
schema.ts 52.73% ⚠️ 26 Missing
utils.ts 87.43% ⚠️ 24 Missing
detector.ts 90.10% ⚠️ 20 Missing
code-scanner.ts 95.00% ⚠️ 16 Missing
fs-utils.ts 57.14% ⚠️ 9 Missing
auth.ts 94.78% ⚠️ 7 Missing
dsn-cache.ts 96.71% ⚠️ 7 Missing
project-root.ts 97.73% ⚠️ 7 Missing
feedback.ts 84.21% ⚠️ 6 Missing
arg-parsing.ts 93.41% ⚠️ 6 Missing
upgrade.ts 93.83% ⚠️ 5 Missing
colors.ts 91.84% ⚠️ 4 Missing
env-file.ts 97.58% ⚠️ 3 Missing
sentry-urls.ts 88.00% ⚠️ 3 Missing
project-aliases.ts 97.40% ⚠️ 2 Missing
project-root-cache.ts 96.92% ⚠️ 2 Missing
alias.ts 99.28% ⚠️ 1 Missing
parser.ts 98.63% ⚠️ 1 Missing
helpers.ts 94.74% ⚠️ 1 Missing
helpers.ts 94.74% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    70.71%    70.71%        —%
==========================================
  Files           55        55         —
  Lines         7445      7445         —
  Branches         0         0         —
==========================================
+ Hits          5264      5264         —
- Misses        2181      2181         —
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK merged commit 267dbee into main Feb 5, 2026
26 checks passed
@BYK BYK deleted the fix/dsn-cache-model-based-tests branch February 5, 2026 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant