fix: parseIssueArg now checks slashes before dashes#177
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 2175 uncovered lines. Files with missing lines (33)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 70.71% 70.81% +0.1%
==========================================
Files 55 55 —
Lines 7445 7451 +6
Branches 0 0 —
==========================================
+ Hits 5264 5276 +12
- Misses 2181 2175 -6
- Partials 0 0 —Generated by Codecov Action |
BREAKING: Changes parsing behavior for inputs like 'my-org/123' Before: 'my-org/123' → project-search (project='my', suffix='org/123') After: 'my-org/123' → explicit-org-numeric (org='my-org', numericId='123') The fix ensures slashes take precedence over dashes, so org slugs with dashes (e.g., 'my-org', 'acme-corp') work correctly with explicit formats. Also includes property-based tests for parseIssueArg and parseOrgProjectArg that verify parsing invariants with randomly generated inputs.
d7e54d3 to
0b9c54b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a parsing bug where org slugs containing dashes (e.g.,
my-org) were incorrectly parsed when used with explicit formats.Supersedes PR #175 (property tests are included here with the fix)
The Bug
The parser was checking for dashes before slashes, causing
my-org/123to split on the dash first.The Fix
Refactored
parseIssueArg()to check slashes FIRST, then handle dashes within each part:numeric/→ parse asorg/...format (slash takes precedence)-→ parse asproject-suffixformatsuffix-onlyChanges
src/lib/arg-parsing.ts: Refactored to check slashes before dashes, extracted helper functions to reduce complexitytest/lib/arg-parsing.property.test.ts: Added 17 property tests that verify parsing invariants with randomly generated inputs (including org slugs with dashes)Verification