test: remove redundant DB tests covered by model-based tests

[BYK]

Summary

Removes two test files that are 100% redundant with the model-based tests in test/lib/db/model-based.test.ts:

• test/lib/db/regions.test.ts (143 lines) - All 5 functions tested are covered by model-based commands:

  • setOrgRegion → SetOrgRegionCommand
  • getOrgRegion → GetOrgRegionCommand
  • setOrgRegions → SetOrgRegionsCommand
  • getAllOrgRegions → GetAllOrgRegionsCommand
  • clearOrgRegions → ClearOrgRegionsCommand

• test/lib/db/version-check.test.ts (68 lines) - Both functions tested are covered:

  • setVersionCheckInfo → SetVersionCheckCommand
  • getVersionCheckInfo → GetVersionCheckCommand

Why model-based tests are superior here

1. Random sequence testing - Model-based tests generate random sequences of operations, catching edge cases that handwritten tests miss
2. Invariant verification - Tests verify system behavior matches the model across all generated scenarios
3. Cross-operation invariants - E.g., clearAuth() also clearing regions is explicitly tested

Impact

• -209 lines of redundant test code
• No coverage loss - all functionality remains tested via model-based tests
• All 1020 tests pass

Part of the test consolidation effort to simplify tests using model-based and property-based testing.

[github-actions]

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

---

New Features ✨

• (dsn) Add project root detection for automatic DSN discovery by BYK in #159
• (issue) Replace --org/--project flags with /ID syntax by BYK in #161
• (lib) Add anyTrue helper for parallel-with-early-exit pattern by BYK in #174
• (telemetry) Add withTracing helper to reduce Sentry span boilerplate by BYK in #172

Bug Fixes 🐛

• (types) Align schema types with Sentry API by betegon in #169
• ParseIssueArg now checks slashes before dashes by BYK in #177
• Address bugbot review comments on dsn-cache model-based tests by BYK in #176
• Added nullable in substatus's zod validation by MathurAditya724 in #157

Internal Changes 🔧

• (upgrade) Use centralized user-agent for GitHub API requests by BYK in #173

Other

• test: remove redundant DB tests covered by model-based tests by BYK in #180

• test: add property tests for async utilities (Phase 4) by BYK in #179
• test: add model-based tests for DSN and project cache by BYK in #171
• test: add model-based and property-based testing with fast-check by BYK in #166

---

_{🤖 This preview updates automatically when you update the PR.}

[github-actions]

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 2175 uncovered lines.
✅ Project coverage is 70.81%. Comparing base (base) to head (head).

Files with missing lines (33)

File	Patch %	Lines
human.ts	31.80%	⚠️ 684 Missing
resolve-target.ts	10.74%	⚠️ 291 Missing
oauth.ts	25.10%	⚠️ 194 Missing
upgrade.ts	40.23%	⚠️ 153 Missing
api-client.ts	74.21%	⚠️ 138 Missing
resolver.ts	3.23%	⚠️ 120 Missing
errors.ts	5.94%	⚠️ 95 Missing
migration.ts	47.44%	⚠️ 82 Missing
version-check.ts	34.04%	⚠️ 62 Missing
telemetry.ts	77.43%	⚠️ 51 Missing
api.ts	89.80%	⚠️ 47 Missing
seer.ts	75.54%	⚠️ 45 Missing
preload.ts	38.71%	⚠️ 38 Missing
seer.ts	79.87%	⚠️ 30 Missing
schema.ts	52.73%	⚠️ 26 Missing
utils.ts	87.43%	⚠️ 24 Missing
detector.ts	90.10%	⚠️ 20 Missing
code-scanner.ts	95.00%	⚠️ 16 Missing
fs-utils.ts	57.14%	⚠️ 9 Missing
auth.ts	94.78%	⚠️ 7 Missing
dsn-cache.ts	96.71%	⚠️ 7 Missing
project-root.ts	97.73%	⚠️ 7 Missing
feedback.ts	84.21%	⚠️ 6 Missing
upgrade.ts	93.83%	⚠️ 5 Missing
colors.ts	91.84%	⚠️ 4 Missing
env-file.ts	97.58%	⚠️ 3 Missing
sentry-urls.ts	88.00%	⚠️ 3 Missing
project-aliases.ts	97.40%	⚠️ 2 Missing
project-root-cache.ts	96.92%	⚠️ 2 Missing
alias.ts	99.28%	⚠️ 1 Missing
parser.ts	98.63%	⚠️ 1 Missing
helpers.ts	94.74%	⚠️ 1 Missing
helpers.ts	94.74%	⚠️ 1 Missing

Coverage diff

@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    70.81%    70.81%        —%
==========================================
  Files           55        55         —
  Lines         7451      7451         —
  Branches         0         0         —
==========================================
+ Hits          5276      5276         —
- Misses        2175      2175         —
- Partials         0         0         —

---

Generated by Codecov Action