fix: use ASCII arrow for consistent terminal rendering#192
Merged
Conversation
Replace Unicode arrow (U+2192) with ASCII "->" in user-facing output to fix rendering issues on terminals/fonts that treat the arrow as ambiguous-width. The Unicode RIGHTWARDS ARROW has East Asian Width "Ambiguous", causing some terminals to render it as 2 cells while advancing the cursor by only 1, which visually "eats" the following space character.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dsn
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊❌ Patch coverage is 25.00%. Project has 2181 uncovered lines. Files with missing lines (33)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 69.82% 70.83% +1.01%
==========================================
Files 55 55 —
Lines 7486 7476 -10
Branches 0 0 —
==========================================
+ Hits 5227 5295 +68
- Misses 2259 2181 -78
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace Unicode arrow
→(U+2192) with ASCII->in user-facing output to fix rendering issues on certain terminals and fonts.Problem
The Unicode RIGHTWARDS ARROW has East Asian Width "Ambiguous", causing some terminals/fonts (e.g., Iosevka) to render it as 2 cells while advancing the cursor by only 1. This visually "eats" the following space character.
Before:
Update available: 0.0.0-dev →0.6.0(space missing after arrow)After:
Update available: 0.0.0-dev -> 0.6.0Changes
src/lib/version-check.ts- Update notificationsrc/lib/formatters/human.ts- Release range, HTTP breadcrumb, navigation breadcrumb