Conversation
Add tests for previously uncovered version-check.ts functionality: - abortPendingVersionCheck: idempotent abort behavior - maybeCheckForUpdateInBackground: probabilistic checking, abort handling - getVersionCheckInfo integration with maybeCheckForUpdateInBackground Coverage improved from 34.04% to 91.14%.
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dsn
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 2111 uncovered lines. Files with missing lines (33)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 70.83% 71.70% +0.87%
==========================================
Files 55 55 —
Lines 7476 7459 -17
Branches 0 0 —
==========================================
+ Hits 5295 5348 +53
- Misses 2181 2111 -70
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands test coverage for
src/lib/version-check.tsby adding tests for previously uncovered functionality.Coverage Impact
src/lib/version-check.tsNew Tests
abortPendingVersionCheck
maybeCheckForUpdateInBackground (expanded)
The remaining uncovered lines (83, 85, 137, 139-140, 158) are error handling paths that require Sentry SDK mocking and would add complexity without significant value.