Skip to content

test: expand version check test coverage#196

Merged
BYK merged 1 commit intomainfrom
byk/test-version-check
Feb 5, 2026
Merged

test: expand version check test coverage#196
BYK merged 1 commit intomainfrom
byk/test-version-check

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 5, 2026

Summary

Expands test coverage for src/lib/version-check.ts by adding tests for previously uncovered functionality.

Coverage Impact

File Before After Change
src/lib/version-check.ts 34.04% 91.14% +57.10%

New Tests

abortPendingVersionCheck

  • Does not throw when no pending check exists
  • Does not throw when called multiple times (idempotent)

maybeCheckForUpdateInBackground (expanded)

  • Initiates check when never checked before
  • Respects probabilistic checking when recently checked
  • Aborts cleanly and allows new checks after abort

The remaining uncovered lines (83, 85, 137, 139-140, 158) are error handling paths that require Sentry SDK mocking and would add complexity without significant value.

Add tests for previously uncovered version-check.ts functionality:
- abortPendingVersionCheck: idempotent abort behavior
- maybeCheckForUpdateInBackground: probabilistic checking, abort handling
- getVersionCheckInfo integration with maybeCheckForUpdateInBackground

Coverage improved from 34.04% to 91.14%.
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Dsn

  • Infer project from directory name when DSN detection fails by BYK in #178
  • Add project root detection for automatic DSN discovery by BYK in #159

Other

  • (issue) Replace --org/--project flags with /ID syntax by BYK in #161
  • (lib) Add anyTrue helper for parallel-with-early-exit pattern by BYK in #174
  • (telemetry) Add withTracing helper to reduce Sentry span boilerplate by BYK in #172

Bug Fixes 🐛

  • (types) Align schema types with Sentry API by betegon in #169
  • Use ASCII arrow for consistent terminal rendering by BYK in #192
  • Corrected the rendering and props for the span tree by MathurAditya724 in #184
  • ParseIssueArg now checks slashes before dashes by BYK in #177
  • Address bugbot review comments on dsn-cache model-based tests by BYK in #176
  • Added nullable in substatus's zod validation by MathurAditya724 in #157

Documentation 📚

  • Update AGENTS.md with testing guidelines and architecture by BYK in #190

Internal Changes 🔧

  • (upgrade) Use centralized user-agent for GitHub API requests by BYK in #173

Other

  • test: expand version check test coverage by BYK in #196
  • test: add comprehensive tests for human formatter utilities by BYK in #191
  • test: add coverage for fetchLatestVersion and versionExists by BYK in #189
  • test: add coverage for UpgradeError and SeerError classes by BYK in #188
  • test: add property tests for sentry-urls.ts (Phase 3) by BYK in #186
  • test: simplify issue-id tests covered by property tests by BYK in #183
  • test: simplify alias and arg-parsing tests covered by property tests by BYK in #182
  • test: add property tests for API command and human formatters by BYK in #181
  • test: remove redundant DB tests covered by model-based tests by BYK in #180
  • test: add property tests for async utilities (Phase 4) by BYK in #179
  • test: add model-based tests for DSN and project cache by BYK in #171
  • test: add model-based and property-based testing with fast-check by BYK in #166

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

Codecov Results 📊

✅ Patch coverage is 100.00%. Project has 2111 uncovered lines.
✅ Project coverage is 71.7%. Comparing base (base) to head (head).

Files with missing lines (33)
File Patch % Lines
human.ts 31.53% ⚠️ 608 Missing
resolve-target.ts 15.28% ⚠️ 366 Missing
oauth.ts 25.10% ⚠️ 194 Missing
upgrade.ts 42.97% ⚠️ 146 Missing
api-client.ts 74.41% ⚠️ 142 Missing
resolver.ts 3.23% ⚠️ 120 Missing
errors.ts 5.94% ⚠️ 95 Missing
migration.ts 47.44% ⚠️ 82 Missing
api.ts 89.80% ⚠️ 47 Missing
telemetry.ts 79.91% ⚠️ 45 Missing
seer.ts 75.54% ⚠️ 45 Missing
seer.ts 79.87% ⚠️ 30 Missing
preload.ts 53.23% ⚠️ 29 Missing
schema.ts 52.73% ⚠️ 26 Missing
utils.ts 87.43% ⚠️ 24 Missing
detector.ts 90.10% ⚠️ 20 Missing
code-scanner.ts 95.00% ⚠️ 16 Missing
arg-parsing.ts 90.00% ⚠️ 12 Missing
dsn-cache.ts 94.62% ⚠️ 12 Missing
fs-utils.ts 57.14% ⚠️ 9 Missing
project-root.ts 97.73% ⚠️ 7 Missing
version-check.ts 91.14% ⚠️ 7 Missing
feedback.ts 84.21% ⚠️ 6 Missing
auth.ts 95.52% ⚠️ 6 Missing
upgrade.ts 93.83% ⚠️ 5 Missing
env-file.ts 97.58% ⚠️ 3 Missing
project-aliases.ts 97.40% ⚠️ 2 Missing
project-root-cache.ts 96.92% ⚠️ 2 Missing
alias.ts 99.28% ⚠️ 1 Missing
parser.ts 98.63% ⚠️ 1 Missing
colors.ts 97.96% ⚠️ 1 Missing
helpers.ts 94.74% ⚠️ 1 Missing
helpers.ts 94.74% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    70.83%    71.70%    +0.87%
==========================================
  Files           55        55         —
  Lines         7476      7459       -17
  Branches         0         0         —
==========================================
+ Hits          5295      5348       +53
- Misses        2181      2111       -70
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK enabled auto-merge (squash) February 5, 2026 15:48
@BYK BYK disabled auto-merge February 5, 2026 15:50
@BYK BYK merged commit ff186b4 into main Feb 5, 2026
23 checks passed
@BYK BYK deleted the byk/test-version-check branch February 5, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant