feat(db): add schema repair and sentry cli fix command#197
Merged
Conversation
Add automatic schema repair for SQLite database migration issues. When a query fails due to missing columns or tables, the CLI now automatically repairs the schema and retries the operation. Also adds a manual `sentry cli fix` command for diagnostics and repair: - `sentry cli fix` - diagnose and repair schema issues - `sentry cli fix --dry-run` - show what would be fixed Auto-repair can be disabled via SENTRY_CLI_NO_AUTO_REPAIR=1 env var.
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dsn
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 91.01%. Project has 1744 uncovered lines. Files with missing lines (34)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 77.20% 77.99% +0.79%
==========================================
Files 57 58 +1
Lines 7497 7922 +425
Branches 0 0 —
==========================================
+ Hits 5788 6178 +390
- Misses 1709 1744 +35
- Partials 0 0 —Generated by Codecov Action |
BYK
commented
Feb 5, 2026
- Refactor EXPECTED_TABLES to generate DDL from TABLE_SCHEMAS (single source of truth) - Move tryRepairAndRetry from telemetry.ts to schema.ts where repair logic belongs - Add addedInVersion tracking to columns for automatic EXPECTED_COLUMNS generation - Remove ~80 lines of duplicate code from telemetry.ts - Fix linting errors (block statements) and type error (EXPECTED_TABLES access)
Member
Author
|
Regarding why migrations are still needed alongside auto-repair: Auto-repair only handles additive schema changes (missing tables/columns). Explicit migrations are still needed for:
Auto-repair is a safety net for when schema version gets out of sync (e.g., database copied between machines, downgrade then upgrade), not a replacement for migrations. |
BYK
commented
Feb 5, 2026
- Export TABLE_SCHEMAS, generateTableDDL, generatePreMigrationTableDDL from schema.ts - Update fix.test.ts to use helpers instead of hardcoded SQL - Update schema.test.ts to use helpers instead of hardcoded SQL - Tests now stay in sync with schema changes automatically
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
- Fix auto-repair swallowing retry errors by moving operation() call outside try-catch, so new errors propagate instead of original error - Reset rawDb to null in getDatabase() auto-invalidate block for consistency - Add validation in generatePreMigrationTableDDL for empty base columns
- Use RepairAttemptResult type to distinguish 'repair not attempted' from 'repair succeeded with undefined result' (fixes incorrect error throwing when stmt.get() legitimately returns undefined) - Wrap database initialization in try-catch to prevent connection leak if initSchema/runMigrations/migrateFromJson fails after Database() opens
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds automatic schema repair for SQLite database migration issues. This fixes cases where the schema version gets out of sync with actual table structure during development.
Changes
Auto-Repair on SQLiteError
db.query()) and execution (stmt.get()) stagesSENTRY_CLI_NO_AUTO_REPAIR=1sentry cli fixCommandSchema Repair Utilities
EXPECTED_TABLES/EXPECTED_COLUMNS- Canonical schema definitionsgetSchemaIssues()- Diagnostics for missing tables/columnsrepairSchema()- Non-destructive repair (only adds, never deletes)Testing