refactor(profile): replace --org/--project flags with positional args#204
Closed
BYK wants to merge 1 commit intofeat/profile-commandfrom
Closed
refactor(profile): replace --org/--project flags with positional args#204BYK wants to merge 1 commit intofeat/profile-commandfrom
BYK wants to merge 1 commit intofeat/profile-commandfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Dsn
Other
Bug Fixes 🐛
Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Contributor
Codecov Results 📊❌ Patch coverage is 25.24%. Project has 2854 uncovered lines. Files with missing lines (42)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 77.99% 66.91% -11.08%
==========================================
Files 58 67 +9
Lines 7933 8624 +691
Branches 0 0 —
==========================================
+ Hits 6187 5770 -417
- Misses 1746 2854 +1108
- Partials 0 0 —Generated by Codecov Action |
Migrate profile view command from --org/--project flags to use the <org>/<project> positional argument syntax for consistency with other commands. Changes: - profile view now uses: sentry profile view [<org>/<project>] <transaction> - Export parsePositionalArgs for unit testing - Add unit tests for parsePositionalArgs - Regenerate SKILL.md
575b879 to
f1484dd
Compare
BYK
added a commit
that referenced
this pull request
Feb 9, 2026
Cherry-pick from refactor/positional-args-flags branch (PR #204). Migrate profile view command from --org/--project flags to use the <org>/<project> positional argument syntax for consistency with other commands. Changes: - profile view now uses: sentry profile view [<org>/<project>] <transaction> - Export parsePositionalArgs for unit testing - Add unit tests for parsePositionalArgs Co-authored-by: Burak Yigit Kaya <byk@sentry.io>
Member
Author
|
Closing in favor of PR #187. The changes from this PR have been cherry-picked into the main profile command PR (#187), which includes additional fixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile viewcommand from--org/--projectflags to<org>/<project>positional argument syntaxMotivation
Ensures consistency with other commands. The
<org>/<project>syntax is more concise and followsghCLI conventions.Changes
Command updated:
sentry profile view [<org>/<project>] <transaction>- now takes optional positional targetRelated
event viewcommand (targeting main)Testing