ref(build): replace local hole-punch script with binpunch package#246
Merged
ref(build): replace local hole-punch script with binpunch package#246
Conversation
Extract the hole-punch build tool into the standalone `binpunch` npm package (https://github.com/BYK/binpunch) and use it as a dev dependency instead of maintaining the code inline.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Build
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4126 uncovered lines. Files with missing lines (71)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 68.44% 68.18% -0.26%
==========================================
Files 109 108 -1
Lines 13249 12968 -281
Branches 0 0 —
==========================================
+ Hits 9068 8842 -226
- Misses 4181 4126 -55
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
script/hole-punch.tswith the publishedbinpunchnpm package (source)script/hole-punch.tsandtest/lib/hole-punch.test.ts(tests now live in the package repo)hole-punchnpm script frompackage.jsonThe build behavior is unchanged —
script/build.tsstill callsprocessBinary()to zero unused ICU data entries before gzip compression.