fix(telemetry): reduce noise from version-check JSON parse errors#253
Merged
fix(telemetry): reduce noise from version-check JSON parse errors#253
Conversation
Replace captureException with span attributes for background version check errors (network failures, truncated JSON from GitHub API). These are transient infrastructure issues, not CLI bugs — recording them as span attributes keeps them queryable in Discover without creating Issues. Also suppress the background version check for `sentry cli setup` and `sentry cli fix`, which are CLI management commands where update notifications are irrelevant. Fixes CLI-K Fixes CLI-5J
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Build
Bug Fixes 🐛Telemetry
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 4094 uncovered lines. Files with missing lines (71)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 68.51% 68.53% +0.02%
==========================================
Files 109 109 —
Lines 13002 13010 +8
Branches 0 0 —
==========================================
+ Hits 8908 8916 +8
- Misses 4094 4094 —
- Partials 0 0 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Address BugBot review: use positional matching (args[0]==="cli") for setup/fix instead of bare SUPPRESSED_ARGS membership, so commands like `sentry issue list --project setup` are not falsely suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background version check errors (
SyntaxError: Unexpected end of JSON input) from GitHub API calls were being reported viacaptureException, creating noise in the Issues feed (CLI-K: 10 events, CLI-5J: 1 event). These are transient infrastructure issues (rate limits, CDN errors, truncated responses), not CLI bugs.captureExceptionwith span attributes (version_check.error,version_check.error_type) so errors remain queryable in Discover without creating Issuessentry cli setupandsentry cli fix— CLI management commands where update notifications are irrelevantFixes CLI-K, CLI-5J