-
-
Notifications
You must be signed in to change notification settings - Fork 18
Closed
Description
Description
We published an alpha release of the sentry-javascript SDKs earlier today and despite it being an alpha-release, the Lambda layer was published.
We brought this up previously in this issue but thought this function prevents publishing the layer:
craft/src/targets/awsLambdaLayer.ts
Lines 196 to 209 in 532b8d1
| private isPushableToRegistry(version: string): boolean { | |
| if (isDryRun()) { | |
| this.logger.info('[dry-run] Not pushing the branch.'); | |
| return false; | |
| } | |
| if (isPreviewRelease(version) && !this.awsLambdaConfig.linkPrereleases) { | |
| // preview release | |
| this.logger.info( | |
| "Preview release detected, not updating the layer's data." | |
| ); | |
| return false; | |
| } | |
| return true; | |
| } |
Upon further reflection, the function is just used to prevent publishing to our release-registry but it does not prevent publishing the layer to AWS.
Expected Result
Pre-releases not to publish our production AWS Lambda layers on AWS.
Actual Result
Pre-release published a new version of our AWS Lambda layer on AWS.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels