fix(changelog-preview): Replace deleted install sub-action with inline install#706
Merged
fix(changelog-preview): Replace deleted install sub-action with inline install#706
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
…e install The install/ sub-action was removed in #705, breaking the changelog-preview workflow which still referenced getsentry/craft/install@master. Replace it with inline install logic that downloads from release: - Respects craft-version input (defaults to latest) - Falls back to latest if specified version not found - Adds robust error handling with set -euo pipefail - Verifies download succeeded and binary is valid - Runs craft --version to confirm installation Note: Dogfooding (using build artifact from PRs) is not implemented because: - Build workflow runs separately with workflow-scoped artifacts - Cross-workflow artifact fetching adds complexity - Changelog preview is less critical than main release action We always use released versions for changelog previews.
BYK
force-pushed
the
fix/changelog-preview-install
branch
from
406a920 to
0c3bc8c
Compare
betegon
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #705 removed the
install/sub-action, but thechangelog-preview.ymlworkflow was still referencing it:This broke the changelog preview workflow for all PRs.
Solution
Replace the deleted sub-action reference with inline install logic that downloads Craft from release:
craft-versioninput (defaults to latest)set -euo pipefailcraft --versionto confirm installationWhy No Dogfooding?
Unlike the main release action, this workflow does not dogfood (use build artifacts from PRs) because:
For changelog previews, we always use the released version of Craft.