Conversation
- Make NEW-VERSION positional argument optional in yargs by using brackets syntax. When omitted, falls back to versioning.policy from .craft.yml. - Auto-create CHANGELOG.md with minimal content when changelog policy is 'auto' and the file doesn't exist. Simple policy still errors on missing file, None policy ignores the file entirely. - Add e2e tests for both scenarios.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Docker
Other
🤖 This preview updates automatically when you update the PR. |
billyvg
approved these changes
Jan 13, 2026
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
looks like mostly formatting changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two usability issues with
craft prepare:Optional version argument:
craft preparenow works without providing aNEW-VERSIONargument, defaulting to theversioning.policyfrom.craft.yml. Previously it showedNot enough non-option arguments: got 0, need at least 1.Auto-create changelog: When
changelog.policyis set toautoandCHANGELOG.mddoesn't exist, it's now automatically created with# Changelogcontent instead of failing.Changes
src/commands/prepare.ts: Change command syntax fromprepare NEW-VERSIONtoprepare [NEW-VERSION](yargs optional positional)src/commands/prepare.ts: Add conditional changelog creation forAutopolicy before the existence checksrc/__tests__/prepare-dry-run.e2e.test.ts: Add e2e tests for both scenariossrc/__tests__/index.test.ts: Update help text expectation