Conversation
…ions When external repos call the reusable workflow via workflow_call, the github.event_name still reflects the original trigger (e.g. workflow_dispatch). This caused the build job and dogfooding steps to run for external repos. Use github.repository check instead to properly distinguish Craft's own releases from external callers.
BYK
changed the title
BYK
added a commit
to getsentry/cli
that referenced
this pull request
Jan 22, 2026
## Summary The reusable Craft workflow has a bug where it runs Craft's internal build/test jobs for external callers (see getsentry/craft#727). Use the `getsentry/craft@v2` action directly instead, like sentry-python does.
betegon
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When external repos call the reusable release workflow via
workflow_call, thegithub.event_namestill reflects the original trigger (e.g.,workflow_dispatchfrom the caller). This caused the build job and dogfooding steps to incorrectly run for external repos.This fix changes the conditions to check
github.repository == 'getsentry/craft'instead ofgithub.event_name, properly distinguishing Craft's own releases from external callers.Changes
github.event_name == 'workflow_dispatch'→github.repository == 'getsentry/craft'github.event_name == 'workflow_dispatch'→github.repository == 'getsentry/craft'github.event_name == 'workflow_call'→github.repository != 'getsentry/craft'