Skip to content

fix(security): Resolve HIGH severity Dependabot alerts#741

Merged
BYK merged 1 commit intomasterfrom
fix/security-vulnerabilities
Feb 6, 2026
Merged

fix(security): Resolve HIGH severity Dependabot alerts#741
BYK merged 1 commit intomasterfrom
fix/security-vulnerabilities

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 6, 2026

Summary

Fixes 2 HIGH severity Dependabot alerts:

  • CVE-2026-25547: @isaacs/brace-expansion DoS via unbounded brace range expansion
  • CVE-2026-25128: fast-xml-parser RangeError DoS via numeric entities

Changes

  • Add pnpm overrides to force patched versions:
    • @isaacs/brace-expansion: ^5.0.1 (was 5.0.0)
    • fast-xml-parser: ^5.3.4 (was 5.2.5)
  • Update @aws-sdk/client-lambda from ^3.723.0 to ^3.984.0

Verification

  • All 806 tests pass
  • Build successful
  • Dependency versions confirmed with pnpm why

- Add pnpm overrides for @isaacs/brace-expansion (^5.0.1) and
  fast-xml-parser (^5.3.4) to fix CVE-2026-25547 and CVE-2026-25128
- Update @aws-sdk/client-lambda from ^3.723.0 to ^3.984.0
@BYK BYK marked this pull request as ready for review February 6, 2026 14:02
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"diff": "^8.0.3"
"diff": "^8.0.3",
"@isaacs/brace-expansion": "^5.0.1",
"fast-xml-parser": "^5.3.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Override forces breaking major version on GCS dependency

High Severity

The fast-xml-parser pnpm override (^5.3.4) is too broad — it forces all instances of the package to v5, including the one used by @google-cloud/storage@7.18.0, which declares a dependency on fast-xml-parser v4.x. The lockfile confirms it previously resolved to 4.5.3 and now resolves to 5.3.4. Since v4→v5 is a major version bump with breaking API changes (different constructor options, changed class behavior), this could cause runtime failures in Google Cloud Storage XML parsing code paths that tests may not cover.

Additional Locations (1)

Fix in Cursor Fix in Web

@BYK BYK merged commit bf5e62f into master Feb 6, 2026
16 checks passed
@BYK BYK deleted the fix/security-vulnerabilities branch February 6, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant