Skip to content

ci: Add TypeScript type checking to CI#747

Merged
BYK merged 1 commit intomasterfrom
byk/ci/typescript-type-checking
Feb 7, 2026
Merged

ci: Add TypeScript type checking to CI#747
BYK merged 1 commit intomasterfrom
byk/ci/typescript-type-checking

Conversation

@BYK
Copy link
Member

@BYK BYK commented Feb 7, 2026

Summary

  • Fix all 215 TypeScript type errors across the codebase
  • Add pnpm typecheck step to the lint CI workflow
  • Enable incremental TypeScript compilation for faster CI runs
  • Fix all ESLint warnings

Changes

Dependencies:

  • Added @types/semver and tslib dev dependencies

Type Fixes:

  • Added TypedTargetConfig<T> utility type for strongly-typed target configs
  • Fixed type issues in 16 target files, utilities, and ~40 test files
  • Cleaned up unused imports across the test suite

CI:

  • Added type checking step before lint in .github/workflows/lint.yml
  • Enabled incremental TS compilation with .tsbuildinfo caching

Lint:

  • Removed unused eslint-disable directives
  • Modernized catch blocks to use catch {} pattern
  • Fixed type-only class exports in mustache.d.ts

Fix all 215 TypeScript type errors and add `pnpm typecheck` to the lint
workflow. This ensures type safety is enforced on all PRs.

Changes:
- Add @types/semver and tslib dependencies
- Add TypedTargetConfig<T> utility for strongly-typed target configs
- Fix type issues in targets, utils, and test files
- Clean up unused imports in ~40 test files
- Enable incremental TypeScript compilation for faster CI
- Fix all ESLint warnings (unused directives, catch bindings)
@BYK BYK marked this pull request as ready for review February 7, 2026 11:53
@BYK BYK merged commit 4760b72 into master Feb 7, 2026
16 checks passed
@BYK BYK deleted the byk/ci/typescript-type-checking branch February 7, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant