This repository was archived by the owner on Aug 14, 2024. It is now read-only.
feat: Docs for Sentry.span #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marandaneto
reviewed
Dec 12, 2022
marandaneto
reviewed
Dec 12, 2022
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
marandaneto
approved these changes
Dec 12, 2022
| of their own transactions, the SDKs should offer a way to expose auto-generated | ||
| transactions. SDKs shall bind auto-generated transactions to the scope, making | ||
| them accessible with `Sentry.span`. | ||
| If the SDK has global mode enabled, which specifies whether to use global scope |
Contributor
There was a problem hiding this comment.
@bruno-garcia - I don't think we currently have defined "global mode" in the unified API spec yet. Have we?
Member
Author
There was a problem hiding this comment.
I'm unsure if we want to add this to the unified API spec.
Member
Author
|
I merged this now, as this PR has been hanging here for a while now. I can make changes with a future PR if you like @bruno-garcia and @mattjohnsonpint. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing docs for this feature and clarify which span to return depending on global mode.