Open
Conversation
Demonstrates that when tracing is disabled (no tracesSampleRate), all errors from different Express requests share the same traceId instead of each getting a unique one. Made-with: Cursor
Made-with: Cursor
e3b4454 to
7386aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction for sentry-javascript#19883
Bug:
instrumentWorkflowWithSentryfrom@sentry/cloudflareswallows theWorkflowStepContext(ctx) parameter instep.docallbacks, makingctx.attempt(and any future context properties)undefined.Root cause:
WrappedWorkflowStep.doinpackages/cloudflare/src/workflows.ts:instrumentedCallbackis typed as() => Promise<T>— drops thectxarg passed by the realstep.douserCallback()is called with zero arguments — doesn't forwardctxHow to run
cd sentry-javascript/19883 node repro.mjsOutput
Made with Cursor