ref(sourcemaps): Remove SourceMapReference struct#2448
Closed
szokeasaurusrex wants to merge 2 commits intomasterfrom
Closed
ref(sourcemaps): Remove SourceMapReference struct#2448szokeasaurusrex wants to merge 2 commits intomasterfrom
SourceMapReference struct#2448szokeasaurusrex wants to merge 2 commits intomasterfrom
Conversation
…ources Remove the branch from `guess_sourcemap_reference` which handles the case of there only being one sourcemap. If there are multiple minified souces, they would all (erroneously) end up associated with the same single sourcemap. Fixes #2438
loewenheim
approved these changes
Mar 28, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/only-one-sourcemap
branch
3 times, most recently
from
ff65a0b to
884faeb
Compare
Member
Author
|
#2447 was changed between this PR being opened and that PR being merged; now we in fact still need the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #2447, we no longer ever set the
SourceMapReferencestruct'soriginal_urlfield to anySome(_)value. This essentially makes the struct unnecessary, since we can just pass the URL values around asStrings.Depends on: