Skip to content

chore(ci): Fallback to macos-14 for React Native check#6043

Merged
philprime merged 1 commit intomainfrom
antonis/rn-test-cross-platform-worflow
Sep 2, 2025
Merged

chore(ci): Fallback to macos-14 for React Native check#6043
philprime merged 1 commit intomainfrom
antonis/rn-test-cross-platform-worflow

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Sep 1, 2025

📜 Description

Similar to getsentry/sentry-react-native#5079 fallsback to macos-14 for RN jobs. An issue has been opened to revisit this getsentry/sentry-react-native#5082

💡 Motivation and Context

Failed CI check https://github.com/getsentry/sentry-cocoa/actions/runs/17321918286/job/49322882904?pr=6018

💚 How did you test it?

CI

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

#skip-changelog

@antonis antonis changed the title DRAFT: Use macos-14 for rn workfow chore(ci): Fallback to macos-14 for React Native check Sep 1, 2025
@antonis antonis marked this pull request as ready for review September 1, 2025 15:06
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it is weird that we need to downgrade, as long as CI passes for now that's fine for me. LGTM

@antonis antonis force-pushed the antonis/rn-test-cross-platform-worflow branch from 62de366 to acbfded Compare September 1, 2025 15:16
@antonis antonis changed the base branch from cursor/implement-integration-test-required-checks-85c4 to main September 1, 2025 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryUIViewControllerSwizzling.m

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Sep 1, 2025
@codecov
Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.734%. Comparing base (2137530) to head (acbfded).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6043       +/-   ##
=============================================
- Coverage   86.774%   86.734%   -0.041%     
=============================================
  Files          425       425               
  Lines        36741     36741               
  Branches     17366     17368        +2     
=============================================
- Hits         31882     31867       -15     
- Misses        4814      4827       +13     
- Partials        45        47        +2     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2137530...acbfded. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.85 ms 1251.96 ms 28.11 ms
Size 23.75 KiB 933.33 KiB 909.59 KiB

Baseline results on branch: cursor/implement-integration-test-required-checks-85c4

Startup times

Revision Plain With Sentry Diff
195fcd0 1232.98 ms 1261.59 ms 28.61 ms

App size

Revision Plain With Sentry Diff
195fcd0 23.75 KiB 928.85 KiB 905.10 KiB

@philprime philprime merged commit 5200f5b into main Sep 2, 2025
175 of 179 checks passed
@philprime philprime deleted the antonis/rn-test-cross-platform-worflow branch September 2, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants