Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
s1gr1d
force-pushed
the
sig/troubleshoot-pnpm
branch
from
45a04fb to
7f8c3a3
Compare
Bundle ReportChanges will decrease total bundle size by 22 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Lms24
approved these changes
Nov 4, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
I think it absolutely makes sense to document this! As discussed, the placement makes sense.
3 tasks
coolguyzone
reviewed
Nov 4, 2024
coolguyzone
approved these changes
Nov 4, 2024
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for the update! Added one small suggestion, looks good to go!
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
s1gr1d
force-pushed
the
sig/troubleshoot-pnpm
branch
from
adaa575 to
821f8f7
Compare
martinhaintz
pushed a commit
that referenced
this pull request
Nov 11, 2024
* master: (39 commits) getsentry/relay@403f2bf feat(native): add backend trade-offs to Advanced Usage (#11721) 🔧 chore(api): add additional troubleshooting instructions to publish api docs (#11772) Bump API schema to 02adb960 (#11773) Update metric-alert-config.mdx (#11760) update w-9 tax form (#11764) chore: silence fetch cache error due to size limit (#11767) fix Ureal engine DSN placeholder (#11769) feat: Banner pathname regex (#11761) docs(nuxt): Add troubleshoot pnpm (#11720) Docker Desktop to Colima fix (#11752) Bump API schema to d51784a6 (#11759) ref(feedback): update user feedback docs to include external issue linking & auto issue creation (#11729) getsentry/relay@d23c39a Changed /store to /envelope (because /store does not exist anymore (#11755) Refactor arcade embeds (#11722) feat(js): Add `skipBrowserExtensionCheck` documentation (#11693) getsentry/relay@a7d9096 fix mermaid charts in dark mode (#11754) fix: Log4j configurations and wording (#11395) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Documenting troubleshooting pnpm, as they don't hoist dependencies.
Problems with pnpm came up in getsentry/sentry-javascript#13917 and getsentry/sentry-javascript#14168
I also updated the information around
@vercel/nftsince nitro released a new version and includes this version upgrade: nitrojs/nitro#2703 (comment)IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: