Skip to content

Describe what happens to invalid email addresses in feedback #14103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jamescrosswell merged 1 commit into from
Jun 25, 2025
Merged

Describe what happens to invalid email addresses in feedback #14103

jamescrosswell merged 1 commit into from
Jun 25, 2025

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Jun 23, 2025

DESCRIBE YOUR PR

Resolves getsentry/sentry-dotnet#4284

See:

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
    cc: @Flash0ver

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Jun 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 4:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Jun 23, 2025 4:48am

@jamescrosswell jamescrosswell requested a review from Flash0ver June 23, 2025 04:30
@codeowner-assignment codeowner-assignment bot requested a review from a team June 23, 2025 04:31
@codecov
Copy link

codecov bot commented Jun 23, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.92MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.8MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 415.85kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/FIbdZ5SEX0QqlWQ2jJF0u/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/FIbdZ5SEX0QqlWQ2jJF0u/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/FvTW7Ps3nSmEtUx56ibmu/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/FvTW7Ps3nSmEtUx56ibmu/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%

@jamescrosswell jamescrosswell linked an issue Jun 24, 2025 that may be closed by this pull request
Document behaviour when Feedback has an invalid email address getsentry/sentry-dotnet#4291
Closed
@jamescrosswell jamescrosswell merged commit a1d85df into master Jun 25, 2025
12 checks passed
@jamescrosswell jamescrosswell deleted the dotnet/capture-feedback-email branch June 25, 2025 20:58
bruno-garcia
bruno-garcia reviewed Jun 30, 2025
View reviewed changes
docs/platforms/dotnet/common/user-feedback/index.mdx

<Alert type="info">

Note that Sentry will reject and drop any feedback events where the email address is invalid. To avoid this, the Sentry SDK for .NET removes invalid email addresses before sending feedback. Ideally you should validate the email address before calling this API.
Copy link
Member

@bruno-garcia bruno-garcia Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem to be the case. at least it didn't originally. I realize it was the conclusion after some github issue with a customer but need to check if relay is doing this to be sure. it's not a dotnet specific thing so not something to put here anyway, should be available on all user feedback docs for all sdks and protocol. cc @aliu39 @cleptric

Copy link
Member

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be available on all user feedback docs for all sdks and protocol.

Agreed, let's decide what the behavior should be though (drop entirely or strip email)

Copy link
Member

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamescrosswell we are deciding to revert the code in sentry that drops feedback with an invalid email, which was a recent change. Of course it's still ideal we get valid emails, so SDK validation is welcome

Copy link
Collaborator Author

@jamescrosswell jamescrosswell Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK thanks @aliu39 - do you have a tracking issue for that? If so, once it's done, we can revert this change to the docs and update the SDK accordingly as well.

Copy link
Member

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just opened getsentry/sentry#94664, once it's deployed docs can be updated

@jamescrosswell jamescrosswell mentioned this pull request Jun 30, 2025
Open
bitsandfoxes pushed a commit that referenced this pull request Jul 3, 2025
@jamescrosswell @bitsandfoxes
Describe what happens to invalid email addresses in feedback (#14103)
dd4c79b 
Resolves getsentry/sentry-dotnet#4284

See:
- getsentry/sentry-dotnet#4284 (comment)
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bruno-garcia bruno-garcia bruno-garcia left review comments

@aliu39 aliu39 aliu39 left review comments

@Flash0ver Flash0ver Flash0ver approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document behaviour when Feedback has an invalid email address

5 participants

@jamescrosswell @bruno-garcia @Flash0ver @aliu39