Skip to content

docs(tanstack-start): Return router from getRouter()#15364

Closed
harshmangalam wants to merge 1 commit intogetsentry:masterfrom
harshmangalam:harsh/hotfix/tanstack-react-docs
Closed

docs(tanstack-start): Return router from getRouter()#15364
harshmangalam wants to merge 1 commit intogetsentry:masterfrom
harshmangalam:harsh/hotfix/tanstack-react-docs

Conversation

@harshmangalam
Copy link

DESCRIBE YOUR PR

return the router variable from getRouter()

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 31, 2025

@harshmangalam is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition.

@s1gr1d s1gr1d changed the title return router from getRouter() docs(tanstack-start): Return router from getRouter() Nov 7, 2025
@s1gr1d
Copy link
Member

s1gr1d commented Nov 10, 2025

Closing this, as I just saw this was added in this PR already: #15425

@s1gr1d s1gr1d closed this Nov 10, 2025
@harshmangalam
Copy link
Author

It's confusing that the PRs were first approved and then closed. As an OSS contributor, this is really disappointing.

@nicohrubec
Copy link
Member

nicohrubec commented Nov 11, 2025

Hi @harshmangalam, I included this change in another PR along with some other fixes I was working on for that page. I missed that there was already a PR open for this. I understand this can be frustrating, sorry about that.

@harshmangalam
Copy link
Author

Thanks for clarification @nicohrubec

@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants