feat(apple): Add documentation for metrics#15822
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Moving back to draft as i just noticed it's outdated |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Replaced the `<Note>` tag with an `<Alert>` tag to emphasize the importance of the `trace_id` being set as a top-level field for distributed tracing correlation in the Apple SDK documentation.
buenaflor
left a comment
buenaflor
left a comment
There was a problem hiding this comment.
I saw javascript uses a new docs format for their metrics page https://docs.sentry.io/platforms/javascript/metrics/
in case you're interested
|
@buenaflor Thanks for the ping. At this point I feel like a lot is moving forward while this PR is not getting reviewed, so I'll keep it as-is and update after the first review round. |
|
Also need to add a link to the SDK on this page: https://docs.sentry.io/product/explore/metrics/getting-started/#mobile |
itaybre
left a comment
itaybre
left a comment
There was a problem hiding this comment.
LGTM, just one small comment
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
Thanks, LGTM with a few minor comments.
sfanahata
left a comment
sfanahata
left a comment
There was a problem hiding this comment.
Generally looks good, just added a couple of comments
6 participants
DESCRIBE YOUR PR
Adds documentation for the new feature Metrics on Apple platforms, based on the JavaScript and Python documentation.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
Closes https://linear.app/getsentry/issue/COCOA-1088/metrics-add-documentation-for-feature
Closes getsentry/sentry-cocoa#7045