-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(dev/logs/metrics): Add sentry.timestamp.sequence definition to the logs and metrics specs
#16492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(dev/logs/metrics): Add sentry.timestamp.sequence definition to the logs and metrics specs
#16492
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
55360da
feat: Add definition to the logs spec
logaretm 2689a7f
ref: rename the attribute
logaretm c32061b
feat: add the attribute to metrics
logaretm 101230f
chore: clarify reset timing
logaretm 3db724f
docs: added a note about being able to omit it if unceessary
logaretm 578eb4d
chore: wording
logaretm 28e1e47
chore: consistency in requirement
logaretm 5f550bf
docs: use more accurate type name
logaretm f761982
docs: use more accurate type name
logaretm abe9484
fix: remove attribute from default attributes to avoid requiring it
logaretm 387a7b2
chore: verb
logaretm e0e4402
fix: verb and default wording
logaretm 428c9a5
fix: updated spec dates
logaretm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this full envelope example, the first metric item includes
sentry.environmentandsentry.release, but this item omits them even though they’re listed as default attributes (when defined) and would normally be consistent across metrics from the same SDK instance. Consider adding them here too, or removing them from the earlier item, so the example matches the spec rules.