-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref: Improve JS SDK Component Tracking Documentation #5619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imatwawana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be put off by all the edits; this is really great! The structure makes much more sense. Mostly this is just styling and wording changes. The only structural edit I'd like you to make that I didn't mention in my suggestions is to please rename the files "componenttracking" and "errorboundary" to "component-tracking" and "error-boundary" in line with other file names, as it makes them easier to read (and then update the links of course). I'd like to look at this one more time before you merge. Just tag me when you're ready for another review! Again, great work and thanks for doing this!
src/platform-includes/getting-started-config/javascript.vue.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/configure-sample-rate/javascript.vue.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/componenttracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/react-native/performance/instrumentation/automatic-instrumentation.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the re-org to angular features. My only thing now is, should we add a CTA for performance on top of these pages? You just did this 😅 - sorry for not looking at the latest diff.features/componenttracking is under the main docs, and not the performance monitoring docs, so it might be harder for folks to understand that way.
Might be also nice to link to features/componenttracking from the Performance Instrumentation docs: (ex. https://sentry-docs-git-lms-improve-component-tracking.sentry.dev/platforms/javascript/guides/react/performance/instrumentation/)
|
@imatwawana thanks for the review. Applied all your feedback and I think this is ready for another round.
I'll address this in a follow-up PR as we need to make a change to the |
mentioned in #5624
|
imatwawana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few final wording and formatting edits. Otherwise LGTM!
src/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/angular/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/react/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/svelte/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/vue/features/component-tracking.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
…cking.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
…g.mdx Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
ff9294b to
3dc57e0
Compare
This PR makes structural, naming and content changes to the documentation of a feature we support in four JS framework SDKs - component tracking. Previously, this documentation differed drastically between these four SDKs, as described in greater detail in #5582. Not only did the location differ, but also, how we called the feature. With this PR, we're introducing one name that describes this feature, while we still find a balance between "component tracking" and however the feature is called in the SDK's code (e.g. "trace helpers" in Angular or "Profiler" in React).
Impacted SDKs: Angular, React, Vue, Svelte
As of this PR, we make the following changes:
All SDKs
Angular:
Vue:
The Vue SDK documentation didn't have a proper page for component tracking previously. Instead it was spread across three pages.
fixes #5582